fix(v2/approvals): render correct title + selected label after click

Approval cards bypass the deliverMessage path that populates
pending_questions, so the post-click lookup found nothing and the
card edit fell back to "❓ Question" + the raw option value
("approve"/"reject"). Store title and normalized options on
pending_approvals as well, and look up either table via a shared
getAskQuestionRender helper so the chat-sdk post-click edit and the
Discord interaction callback render the per-card title and the
selectedLabel (e.g. "✅ Approved").

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

src/db/migrations/003-pending-approvals.ts

@@ -29,7 +29,9 @@ export const migration003: Migration = {
         platform_id         TEXT,
         platform_message_id TEXT,
         expires_at          TEXT,
-        status              TEXT NOT NULL DEFAULT 'pending'
+        status              TEXT NOT NULL DEFAULT 'pending',
+        title               TEXT NOT NULL DEFAULT '',
+        options_json        TEXT NOT NULL DEFAULT '[]'
       );
 
       CREATE INDEX idx_pending_approvals_action_status

src/db/sessions.ts

@@ -108,16 +108,21 @@ export function deletePendingQuestion(questionId: string): void {
 
 export function createPendingApproval(
   pa: Partial<PendingApproval> &
-    Pick<PendingApproval, 'approval_id' | 'request_id' | 'action' | 'payload' | 'created_at'>,
+    Pick<
+      PendingApproval,
+      'approval_id' | 'request_id' | 'action' | 'payload' | 'created_at' | 'title' | 'options_json'
+    >,
 ): void {
   getDb()
     .prepare(
       `INSERT INTO pending_approvals
          (approval_id, session_id, request_id, action, payload, created_at,
-          agent_group_id, channel_type, platform_id, platform_message_id, expires_at, status)
+          agent_group_id, channel_type, platform_id, platform_message_id, expires_at, status,
+          title, options_json)
        VALUES
          (@approval_id, @session_id, @request_id, @action, @payload, @created_at,
-          @agent_group_id, @channel_type, @platform_id, @platform_message_id, @expires_at, @status)`,
+          @agent_group_id, @channel_type, @platform_id, @platform_message_id, @expires_at, @status,
+          @title, @options_json)`,
     )
     .run({
       session_id: null,
@@ -148,3 +153,20 @@ export function deletePendingApproval(approvalId: string): void {
 export function getPendingApprovalsByAction(action: string): PendingApproval[] {
   return getDb().prepare('SELECT * FROM pending_approvals WHERE action = ?').all(action) as PendingApproval[];
 }
+
+/**
+ * Resolve ask_question render metadata (title + normalized options) for any
+ * card, regardless of whether it was persisted as a pending_question (generic
+ * ask_user_question) or a pending_approval (self-mod / OneCLI credential).
+ */
+export function getAskQuestionRender(
+  id: string,
+): { title: string; options: import('../channels/ask-question.js').NormalizedOption[] } | undefined {
+  const q = getPendingQuestion(id);
+  if (q) return { title: q.title, options: q.options };
+  const a = getDb()
+    .prepare('SELECT title, options_json FROM pending_approvals WHERE approval_id = ?')
+    .get(id) as { title: string; options_json: string } | undefined;
+  if (!a || !a.title) return undefined;
+  return { title: a.title, options: JSON.parse(a.options_json) };
+}