Before, every provider stored its opaque continuation id under the single outbound.db key `sdk_session_id`. Flipping a session's agent_provider (e.g. Codex → Claude) meant the new provider read the old provider's id at wake, handed it to its own SDK, and got a "No conversation found" error that cost the user one sacrificed message before the stale-session recovery path cleared the id. This reshapes session_state so continuations are keyed `continuation:<provider>` instead. Consequences: - Per-provider continuations coexist. Flipping Claude → Codex → Claude resumes the Claude thread exactly where it left off, with the intervening Codex thread also still on file. - No provider ever reads another provider's id. Switching costs no sacrificed message and emits no transient error. - Legacy installs are migrated forward on first startup: migrateLegacyContinuation() adopts any pre-existing `sdk_session_id` row into the current provider's slot (best guess — it was whichever provider ran last), then deletes the legacy row unconditionally so it can't poison a future provider's read. runPollLoop now takes providerName alongside the provider instance, and threads it through processQuery to setContinuation on init. Tests: 9 new tests covering set/get isolation across providers, clear-specificity, legacy-adoption, legacy-always-deleted, prefer-existing-slot-over-legacy, and idempotency of a second migration call. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
122 lines
4.4 KiB
TypeScript
122 lines
4.4 KiB
TypeScript
import { describe, it, expect, beforeEach, afterEach } from 'bun:test';
|
|
|
|
import { initTestSessionDb, closeSessionDb, getInboundDb, getOutboundDb } from './db/connection.js';
|
|
import { getUndeliveredMessages } from './db/messages-out.js';
|
|
import { getPendingMessages } from './db/messages-in.js';
|
|
import { MockProvider } from './providers/mock.js';
|
|
import { runPollLoop } from './poll-loop.js';
|
|
|
|
beforeEach(() => {
|
|
initTestSessionDb();
|
|
// Seed a destination so output parsing can resolve "discord-test" → routing
|
|
getInboundDb()
|
|
.prepare(
|
|
`INSERT INTO destinations (name, display_name, type, channel_type, platform_id, agent_group_id)
|
|
VALUES ('discord-test', 'Discord Test', 'channel', 'discord', 'chan-1', NULL)`,
|
|
)
|
|
.run();
|
|
});
|
|
|
|
afterEach(() => {
|
|
closeSessionDb();
|
|
});
|
|
|
|
function insertMessage(id: string, content: object, opts?: { platformId?: string; channelType?: string; threadId?: string }) {
|
|
getInboundDb()
|
|
.prepare(
|
|
`INSERT INTO messages_in (id, kind, timestamp, status, platform_id, channel_type, thread_id, content)
|
|
VALUES (?, 'chat', datetime('now'), 'pending', ?, ?, ?, ?)`,
|
|
)
|
|
.run(id, opts?.platformId ?? null, opts?.channelType ?? null, opts?.threadId ?? null, JSON.stringify(content));
|
|
}
|
|
|
|
describe('poll loop integration', () => {
|
|
it('should pick up a message, process it, and write a response', async () => {
|
|
insertMessage('m1', { sender: 'Alice', text: 'What is the meaning of life?' }, { platformId: 'chan-1', channelType: 'discord', threadId: 'thread-1' });
|
|
|
|
const provider = new MockProvider({}, () => '<message to="discord-test">42</message>');
|
|
|
|
const controller = new AbortController();
|
|
const loopPromise = runPollLoopWithTimeout(provider, controller.signal, 2000);
|
|
|
|
await waitFor(() => getUndeliveredMessages().length > 0, 2000);
|
|
controller.abort();
|
|
|
|
const out = getUndeliveredMessages();
|
|
expect(out).toHaveLength(1);
|
|
expect(JSON.parse(out[0].content).text).toBe('42');
|
|
expect(out[0].platform_id).toBe('chan-1');
|
|
expect(out[0].channel_type).toBe('discord');
|
|
expect(out[0].in_reply_to).toBe('m1');
|
|
|
|
// Input message should be acked (not pending)
|
|
const pending = getPendingMessages();
|
|
expect(pending).toHaveLength(0);
|
|
|
|
await loopPromise.catch(() => {});
|
|
});
|
|
|
|
it('should process multiple messages in a batch', async () => {
|
|
insertMessage('m1', { sender: 'Alice', text: 'Hello' });
|
|
insertMessage('m2', { sender: 'Bob', text: 'World' });
|
|
|
|
const provider = new MockProvider({}, () => '<message to="discord-test">Got both messages</message>');
|
|
const controller = new AbortController();
|
|
const loopPromise = runPollLoopWithTimeout(provider, controller.signal, 2000);
|
|
|
|
await waitFor(() => getUndeliveredMessages().length > 0, 2000);
|
|
controller.abort();
|
|
|
|
const out = getUndeliveredMessages();
|
|
expect(out).toHaveLength(1);
|
|
expect(JSON.parse(out[0].content).text).toBe('Got both messages');
|
|
|
|
await loopPromise.catch(() => {});
|
|
});
|
|
|
|
it('should process messages arriving after loop starts', async () => {
|
|
const provider = new MockProvider({}, () => '<message to="discord-test">Processed</message>');
|
|
const controller = new AbortController();
|
|
const loopPromise = runPollLoopWithTimeout(provider, controller.signal, 3000);
|
|
|
|
// Insert message after loop has started
|
|
await sleep(200);
|
|
insertMessage('m-late', { sender: 'Charlie', text: 'Late arrival' });
|
|
|
|
await waitFor(() => getUndeliveredMessages().length > 0, 2000);
|
|
controller.abort();
|
|
|
|
const out = getUndeliveredMessages();
|
|
expect(out.length).toBeGreaterThanOrEqual(1);
|
|
|
|
await loopPromise.catch(() => {});
|
|
});
|
|
});
|
|
|
|
// Helper: run poll loop until aborted or timeout
|
|
async function runPollLoopWithTimeout(provider: MockProvider, signal: AbortSignal, timeoutMs: number): Promise<void> {
|
|
return Promise.race([
|
|
runPollLoop({
|
|
provider,
|
|
providerName: 'mock',
|
|
cwd: '/tmp',
|
|
}),
|
|
new Promise<void>((_, reject) => {
|
|
signal.addEventListener('abort', () => reject(new Error('aborted')));
|
|
}),
|
|
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('timeout')), timeoutMs)),
|
|
]);
|
|
}
|
|
|
|
async function waitFor(condition: () => boolean, timeoutMs: number): Promise<void> {
|
|
const start = Date.now();
|
|
while (!condition()) {
|
|
if (Date.now() - start > timeoutMs) throw new Error('waitFor timeout');
|
|
await sleep(50);
|
|
}
|
|
}
|
|
|
|
function sleep(ms: number): Promise<void> {
|
|
return new Promise((resolve) => setTimeout(resolve, ms));
|
|
}
|