fix: stop mode filter stripping rule bullets with a colon

filterSkillBodyForMode only filters lines whose label is a real mode (lite/full/ultra). Rule bullets like 'No unrequested abstractions:' and the 'ponytail:' comment convention were being stripped from injected instructions in every mode. Adds regression test.
This commit is contained in:
Paul Ogier
2026-06-13 01:43:26 +02:00
committed by GitHub
parent 8c279cbfb3
commit c15db8d3c9
2 changed files with 31 additions and 4 deletions
+14 -4
View File
@@ -12,14 +12,24 @@ function filterSkillBodyForMode(body, mode) {
const effectiveMode = normalizeMode(mode) || DEFAULT_MODE; const effectiveMode = normalizeMode(mode) || DEFAULT_MODE;
const withoutFrontmatter = String(body || '').replace(/^---[\s\S]*?---\s*/, ''); const withoutFrontmatter = String(body || '').replace(/^---[\s\S]*?---\s*/, '');
// Only the intensity table rows and worked examples are mode-specific, and
// both are keyed by a mode name (lite/full/ultra). A bullet whose label is
// not a mode — e.g. "No unrequested abstractions: ..." — is a normal rule
// and must be kept verbatim.
return withoutFrontmatter return withoutFrontmatter
.split(/\r?\n/) .split(/\r?\n/)
.filter((line) => { .filter((line) => {
const tableMatch = line.match(/^\|\s*\*\*(.+?)\*\*\s*\|/); const tableLabel = line.match(/^\|\s*\*\*(.+?)\*\*\s*\|/);
if (tableMatch) return tableMatch[1].trim() === effectiveMode; if (tableLabel) {
const labelMode = normalizeMode(tableLabel[1].trim());
if (labelMode) return labelMode === effectiveMode;
}
const exampleMatch = line.match(/^-\s*([^:]+):\s*/); const exampleLabel = line.match(/^-\s*([^:]+):\s*/);
if (exampleMatch) return exampleMatch[1].trim() === effectiveMode; if (exampleLabel) {
const labelMode = normalizeMode(exampleLabel[1].trim());
if (labelMode) return labelMode === effectiveMode;
}
return true; return true;
}) })
+17
View File
@@ -66,3 +66,20 @@ test("filterSkillBodyForMode keeps only requested intensity examples and rows",
assert.ok(filtered.includes("Ultra example")); assert.ok(filtered.includes("Ultra example"));
assert.ok(filtered.includes("Other line")); assert.ok(filtered.includes("Other line"));
}); });
test("filterSkillBodyForMode keeps rule bullets that contain a colon", () => {
// Regression: rule bullets outside the Intensity section (e.g. the
// "No unrequested abstractions:" rule or the `ponytail:` comment convention)
// contain a colon and must not be mistaken for mode-example lines.
const skillPath = join(import.meta.dirname, "..", "..", "skills", "ponytail", "SKILL.md");
const body = readFileSync(skillPath, "utf8");
const filtered = filterSkillBodyForMode(body, "full");
assert.ok(filtered.includes("No unrequested abstractions"));
assert.ok(filtered.includes("Mark deliberate simplifications"));
// The Intensity examples are still filtered down to the active mode.
assert.ok(filtered.includes('full: "`@lru_cache'));
assert.ok(!filtered.includes('lite: "Done'));
assert.ok(!filtered.includes('ultra: "No cache'));
});