* feat: inject ponytail ruleset into subagents via SubagentStart hook SessionStart additionalContext is parent-thread only, so every Task-spawned agent ran ponytail-unaware. Add a SubagentStart hook that injects the active ruleset into each subagent, reusing getPonytailInstructions. Native Claude needs the hookSpecificOutput JSON form (not raw stdout), so writeHookOutput grows a SubagentStart branch; readMode exposes the live flag. Workflow- and team-spawned coverage is undocumented upstream; verify in a fresh session once installed. Closes #252 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H1dMag33yz1Kf1jS24Aira * fix: address QA round 1 — make hook tests hermetic + cover Codex SubagentStart QA round 1 (panel + deepseek-v4-pro) found two real test issues: - The new subagent block (and the pre-existing claudeEnv block) used a no-op `delete env.PLUGIN_DATA`; run() spreads process.env, so a PLUGIN_DATA / COPILOT_PLUGIN_DATA leaked from the shell would steer writeHookOutput into the codex/copilot branch and silently mis-fire the native-Claude assertions. Fixed at the source: neutralize both vars once at the top, like CLAUDE_CONFIG_DIR. - The Codex SubagentStart branch (claude-codex-hooks.json is shared by both plugin manifests) had zero coverage. Added a codex-path assertion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H1dMag33yz1Kf1jS24Aira * fix: use PowerShell-safe command form for SubagentStart hook Match the post-#265 'node ...; exit 0' form used by the sibling hooks. The old 'command -v node ... || exit 0' form fails tests/hooks-windows.test.js (POSIX-guard and non-blocking asserts) once this branch merges onto current main. --------- Co-authored-by: Shane McCarron <shane.mccarron@corvexconnect.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Emeriko <dietrich.gebert@gmail.com>
213 lines
7.6 KiB
JavaScript
213 lines
7.6 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
const path = require('path');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
const root = path.join(__dirname, '..');
|
|
|
|
// isShellSafe gates the statusline setup snippet (issue #200): ordinary install
|
|
// paths pass, paths carrying shell metacharacters are rejected so they never get
|
|
// embedded in a shell command.
|
|
const { isShellSafe } = require('../hooks/ponytail-config');
|
|
assert.equal(isShellSafe('C:\\Users\\x\\.claude\\plugins\\ponytail\\hooks\\ponytail-statusline.ps1'), true);
|
|
assert.equal(isShellSafe('/home/u/.claude/plugins/ponytail/hooks/ponytail-statusline.sh'), true);
|
|
assert.equal(isShellSafe('/tmp/a"&calc.exe&"/x.sh'), false);
|
|
assert.equal(isShellSafe('/tmp/$(calc)/x.sh'), false);
|
|
assert.equal(isShellSafe('/tmp/a;rm -rf/x.sh'), false);
|
|
|
|
function run(script, env, input = '') {
|
|
return spawnSync(process.execPath, [path.join(root, 'hooks', script)], {
|
|
env: { ...process.env, ...env },
|
|
input,
|
|
encoding: 'utf8',
|
|
});
|
|
}
|
|
|
|
// Keep the base env clean so the default-dir / native-Claude checks are
|
|
// deterministic; the CLAUDE_CONFIG_DIR and codex/copilot cases set these
|
|
// explicitly where needed. run() spreads process.env, so a PLUGIN_DATA /
|
|
// COPILOT_PLUGIN_DATA leaked from the dev or CI shell would otherwise steer
|
|
// writeHookOutput into the wrong branch and mis-fire the native assertions.
|
|
delete process.env.CLAUDE_CONFIG_DIR;
|
|
delete process.env.PLUGIN_DATA;
|
|
delete process.env.COPILOT_PLUGIN_DATA;
|
|
|
|
const temp = fs.mkdtempSync(path.join(os.tmpdir(), 'ponytail-hooks-'));
|
|
// Runs on normal exit and on assertion-throw exit; force makes it idempotent.
|
|
process.on('exit', () => fs.rmSync(temp, { recursive: true, force: true }));
|
|
|
|
const home = path.join(temp, 'home');
|
|
const pluginData = path.join(temp, 'plugin-data');
|
|
fs.mkdirSync(home, { recursive: true });
|
|
|
|
// USERPROFILE alongside HOME: os.homedir() reads USERPROFILE on Windows, HOME on POSIX.
|
|
const codexEnv = {
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
PLUGIN_DATA: pluginData,
|
|
PONYTAIL_DEFAULT_MODE: 'ultra',
|
|
};
|
|
const codexState = path.join(pluginData, '.ponytail-active');
|
|
|
|
let result = run('ponytail-activate.js', codexEnv);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(fs.readFileSync(codexState, 'utf8'), 'ultra');
|
|
let output = JSON.parse(result.stdout);
|
|
assert.equal(output.systemMessage, 'PONYTAIL:ULTRA');
|
|
assert.match(
|
|
output.hookSpecificOutput.additionalContext,
|
|
/PONYTAIL MODE ACTIVE — level: ultra/,
|
|
);
|
|
|
|
result = run(
|
|
'ponytail-mode-tracker.js',
|
|
codexEnv,
|
|
JSON.stringify({ prompt: '@ponytail lite' }),
|
|
);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(fs.readFileSync(codexState, 'utf8'), 'lite');
|
|
output = JSON.parse(result.stdout);
|
|
assert.equal(output.systemMessage, 'PONYTAIL:LITE');
|
|
|
|
result = run(
|
|
'ponytail-mode-tracker.js',
|
|
codexEnv,
|
|
JSON.stringify({ prompt: 'normal mode' }),
|
|
);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(fs.existsSync(codexState), false);
|
|
output = JSON.parse(result.stdout);
|
|
assert.equal(output.systemMessage, 'PONYTAIL:OFF');
|
|
|
|
// A request that merely mentions "normal mode" must not deactivate ponytail.
|
|
result = run('ponytail-mode-tracker.js', codexEnv, JSON.stringify({ prompt: '@ponytail lite' }));
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(fs.readFileSync(codexState, 'utf8'), 'lite');
|
|
|
|
result = run(
|
|
'ponytail-mode-tracker.js',
|
|
codexEnv,
|
|
JSON.stringify({ prompt: 'add a normal mode toggle next to dark mode' }),
|
|
);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(
|
|
fs.readFileSync(codexState, 'utf8'),
|
|
'lite',
|
|
'incidental "normal mode" in a request must not turn ponytail off',
|
|
);
|
|
|
|
const claudeEnv = {
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
PONYTAIL_DEFAULT_MODE: 'full',
|
|
};
|
|
delete claudeEnv.PLUGIN_DATA;
|
|
|
|
result = run('ponytail-activate.js', claudeEnv);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(
|
|
fs.readFileSync(path.join(home, '.claude', '.ponytail-active'), 'utf8'),
|
|
'full',
|
|
);
|
|
|
|
// CLAUDE_CONFIG_DIR overrides ~/.claude for the flag file (issue #34).
|
|
const home2 = path.join(temp, 'home2');
|
|
fs.mkdirSync(home2, { recursive: true });
|
|
const customConfigDir = path.join(temp, 'custom-claude');
|
|
result = run('ponytail-activate.js', {
|
|
HOME: home2,
|
|
USERPROFILE: home2,
|
|
CLAUDE_CONFIG_DIR: customConfigDir,
|
|
PONYTAIL_DEFAULT_MODE: 'lite',
|
|
});
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(
|
|
fs.readFileSync(path.join(customConfigDir, '.ponytail-active'), 'utf8'),
|
|
'lite',
|
|
);
|
|
assert.equal(
|
|
fs.existsSync(path.join(home2, '.claude', '.ponytail-active')),
|
|
false,
|
|
'flag must not land in ~/.claude when CLAUDE_CONFIG_DIR is set',
|
|
);
|
|
|
|
const copilotData = path.join(temp, 'copilot-data');
|
|
const codexData = path.join(temp, 'codex-data-shadow');
|
|
result = run('ponytail-activate.js', {
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
COPILOT_PLUGIN_DATA: copilotData,
|
|
PLUGIN_DATA: codexData,
|
|
PONYTAIL_DEFAULT_MODE: 'full',
|
|
});
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(fs.readFileSync(path.join(copilotData, '.ponytail-active'), 'utf8'), 'full');
|
|
assert.equal(
|
|
fs.existsSync(path.join(codexData, '.ponytail-active')),
|
|
false,
|
|
'copilot hooks must not write mode state to codex PLUGIN_DATA',
|
|
);
|
|
output = JSON.parse(result.stdout);
|
|
assert.match(output.additionalContext, /PONYTAIL MODE ACTIVE — level: full/);
|
|
|
|
result = run(
|
|
'ponytail-mode-tracker.js',
|
|
{
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
COPILOT_PLUGIN_DATA: copilotData,
|
|
PLUGIN_DATA: codexData,
|
|
},
|
|
JSON.stringify({ prompt: '/ponytail ultra' }),
|
|
);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(fs.readFileSync(path.join(copilotData, '.ponytail-active'), 'utf8'), 'ultra');
|
|
assert.equal(
|
|
fs.existsSync(path.join(codexData, '.ponytail-active')),
|
|
false,
|
|
'copilot mode tracker must keep codex PLUGIN_DATA untouched',
|
|
);
|
|
output = JSON.parse(result.stdout);
|
|
assert.deepEqual(output, {});
|
|
|
|
// SubagentStart hook: when ponytail mode is active it injects the ruleset into
|
|
// each subagent (issue #252). Native Claude must get the hookSpecificOutput JSON
|
|
// form, not raw stdout, or the context is dropped.
|
|
const subHome = path.join(temp, 'sub-home');
|
|
const subFlag = path.join(subHome, '.claude', '.ponytail-active');
|
|
fs.mkdirSync(path.dirname(subFlag), { recursive: true });
|
|
const subEnv = { HOME: subHome, USERPROFILE: subHome };
|
|
|
|
fs.writeFileSync(subFlag, 'full');
|
|
result = run('ponytail-subagent.js', subEnv);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
output = JSON.parse(result.stdout);
|
|
assert.equal(output.hookSpecificOutput.hookEventName, 'SubagentStart');
|
|
assert.match(
|
|
output.hookSpecificOutput.additionalContext,
|
|
/PONYTAIL MODE ACTIVE — level: full/,
|
|
);
|
|
|
|
// No flag → ponytail off → inject nothing (empty stdout, no failure).
|
|
fs.unlinkSync(subFlag);
|
|
result = run('ponytail-subagent.js', subEnv);
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(result.stdout, '', 'SubagentStart must stay silent when ponytail is off');
|
|
|
|
// Codex shares claude-codex-hooks.json, so SubagentStart is reachable under Codex
|
|
// too — assert the codex branch emits the badge plus hookSpecificOutput.
|
|
const subCodex = path.join(temp, 'sub-codex');
|
|
fs.mkdirSync(subCodex, { recursive: true });
|
|
fs.writeFileSync(path.join(subCodex, '.ponytail-active'), 'full');
|
|
result = run('ponytail-subagent.js', { HOME: subHome, USERPROFILE: subHome, PLUGIN_DATA: subCodex });
|
|
assert.equal(result.status, 0, result.stderr);
|
|
output = JSON.parse(result.stdout);
|
|
assert.equal(output.systemMessage, 'PONYTAIL:FULL');
|
|
assert.equal(output.hookSpecificOutput.hookEventName, 'SubagentStart');
|
|
assert.match(output.hookSpecificOutput.additionalContext, /PONYTAIL MODE ACTIVE — level: full/);
|
|
|
|
console.log('hook compatibility checks passed');
|